[wp-trac] [WordPress Trac] #37305: Custom Logo: output invalid according to the W3C

WordPress Trac noreply at wordpress.org
Wed Mar 27 12:15:21 UTC 2019


#37305: Custom Logo: output invalid according to the W3C
------------------------------+-----------------------------
 Reporter:  henry.wright      |       Owner:  SergeyBiryukov
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  5.2
Component:  Themes            |     Version:  4.5
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"45028" 45028]:
 {{{
 #!CommitTicketReference repository="" revision="45028"
 Themes: Remove `itemprop="url"` from `get_custom_logo()` output.

 Making incorrect assumptions about microdata used in a theme results in
 invalid markup.

 The attribute can still be added using the `get_custom_logo` or
 `wp_get_attachment_image_attributes` filter, but it should not be added by
 default.

 Props henry.wright, tfrommen, afercia, markcallen, zodiac1978.
 Fixes #37305.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37305#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list