[wp-trac] [WordPress Trac] #46618: Change login behaviour to only set the test cookie when a user attempts to login instead of just on visiting the login page

WordPress Trac noreply at wordpress.org
Mon Mar 25 06:14:28 UTC 2019


#46618: Change login behaviour to only set the test cookie when a user attempts to
login instead of just on visiting the login page
------------------------------------+----------------------------------
 Reporter:  garrett-eclipse         |       Owner:  (none)
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Login and Registration  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:                          |     Focuses:  javascript, privacy
------------------------------------+----------------------------------

Comment (by garrett-eclipse):

 Replying to [comment:1 Clorith]:
 > If this were the case, do we even need the test cookie? You're trying to
 log in already and if it fails passes but you're still not logged in then
 cookies are a problem.
 >
 > Personally, I'd prefer knowing that I can't login because cookies are
 disabled before I type in, and then send, my username and password.

 Hi @Clorith thanks for the feedback.

 Taking a look at the existing login process it appears the cookie error
 occurs after login attempt and not before. I agree it would be useful to
 know before login that cookies are needed and that you may not have them
 enabled.

 A potential other flow could be introduce a cookie checkbox similar to the
 one on comment forms disclaiming the cookie usage, checking the box would
 attempt to set the cookie via javascript or making a call to
 navigator.cookieEnabled and if that fails display the cookie error.

 Thoughts?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46618#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list