[wp-trac] [WordPress Trac] #46312: Replace http with https in custom links menu item

[WordPress Trac]

#46312: Replace http with https in custom links menu item
-----------------------------------------+-----------------------
 Reporter:  aksl95                       |       Owner:  audrasjb
     Type:  enhancement                  |      Status:  accepted
 Priority:  normal                       |   Milestone:  5.2
Component:  Menus                        |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-screenshots needs-patch  |     Focuses:
-----------------------------------------+-----------------------

Comment (by audrasjb):

 Thanks for your comment @celloexpressions
 I don't think value is a good idea since this attribute is supposed to
 specifiy a default value. Placeholders should be used to specify an
 example value.

 By the way, I updated the patch.
 In `46312.3.diff`:
 1. Add https to both menu and customizer screens
 2. Replace `value` with `placeholder`
 3. Updates the custom link check to handle both `http://`, `https://` and
 empty value… though it should be empty all the time now we don't have any
 default value anymore. But… worth it :)

 @SergeyBiryukov if you have a chance, can you please check what I say in
 the item 3) above in the last patch `46312.3.diff` ?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46312#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform