[wp-trac] [WordPress Trac] #45989: WSODs protection still 500 on REST API request

[WordPress Trac]

#45989: WSODs protection still 500 on REST API request
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:  schlessera
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.2
Component:  Bootstrap/Load                       |     Version:  trunk
 Severity:  major                                |  Resolution:
 Keywords:  needs-patch servehappy needs-        |     Focuses:  multisite
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by flixos90):

 I agree we should find a better solution, and I agree with both your
 thoughts.

 How about the following:
 * We remove the whole `WP_EXECUTION_SUCCEEDED` thing entirely.
 * In the fatal error handler, if `headers_sent()`, we don't display
 anything custom - as in we don't call `wp_die()` or print a custom
 message. In that case, all we do is the internal error handling (e.g.
 recovery mode). Displaying anything about the error would defer to what
 happens by default.

 Reasons for omitting the display part under these circumstances:
 * We can't predict how our custom message will mess up / conflict with
 already rendered output, possibly worse than before.
 * The nicely formatted error notification is useful, but not super crucial
 to have in all cases.
 * Most fatal errors probably happen before sending headers, so impact of
 omitting wouldn't be too significant.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45989#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform