[wp-trac] [WordPress Trac] #32096: Twenty Fifteen: author-bio.php clashes with "bio" username

[WordPress Trac]

#32096: Twenty Fifteen: author-bio.php clashes with "bio" username
-------------------------------------------------+-------------------------
 Reporter:  lordlod                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Bundled Theme                        |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch dev-feedback bulk-         |     Focuses:
  reopened                                       |
-------------------------------------------------+-------------------------
Changes (by ianbelanger):

 * keywords:  has-patch, dev-feedback, bulk-reopened => has-patch dev-
     feedback bulk-reopened
 * version:  4.0 => trunk


Comment:

 IMO, this issue breaks a page which is available for anyone to view and
 can be crawled by the SE bots. So even though it might be an "edge" case,
 it is still something that should be fixed. I'm not sure that I agree that
 the current fix is that impactful either. It only effects template loading
 for this particular issue. Also, I'm not sure that there is a better way
 to handle it.

 All that being said, I tested the most recent patch and it failed to
 apply, so I updated the patch against trunk. While doing so, I noticed
 another issue with the previous fix. If the author named `bio` did not
 have any published posts, then the previous fix did not work, so I updated
 the patch to check against the authors post number.

 32096.4.diff addresses all of these things:

 * Refreshed patch against current trunk
 * Better targeted function names to their particular theme
 * Updated @since for both themes
 * Added conditional check for authors published post number

 I understand that there are differing opinions on whether this should be
 fixed, so if there are any objections to fixing this, please state your
 case. Otherwise, in the interest of closing out old tickets, I will
 recommend that this be committed into the bundled themes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/32096#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform