[wp-trac] [WordPress Trac] #37782: Duplicate Page Entry in View All Pages when generating a Menu

[WordPress Trac]

#37782: Duplicate Page Entry in View All Pages when generating a Menu
-------------------------------------+-------------------------------------
 Reporter:  garrett-eclipse          |       Owner:  garrett-eclipse
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.2
Component:  Menus                    |     Version:  3.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, administration,
  has-unit-tests                     |  privacy
-------------------------------------+-------------------------------------

Comment (by garrett-eclipse):

 After some manual testing I realized that the issue originally identified
 in test_should_contain_no_items_without_pages was a valid issue so updated
 the patch to use`suppress_page_ids` instead of `important_pages` in the
 check for `No Items` as important_pages always contains at minimum the
 Home object placeholder menu item.
 [https://core.trac.wordpress.org/attachment/ticket/37782/37782.9.diff
 37782.9.diff] addresses this issue and reverts the
 test_should_contain_no_items_without_pages test to check for 'No items'

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37782#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform