[wp-trac] [WordPress Trac] #45361: Integer menu slugs should not be supported

[WordPress Trac]

#45361: Integer menu slugs should not be supported
-------------------------------------+-----------------------
 Reporter:  desrosj                  |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.2
Component:  Menus                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+-----------------------
Changes (by desrosj):

 * keywords:  has-patch reporter-feedback => has-patch needs-refresh


Comment:

 Thanks for working on this, @audrasjb!

 Some feedback:

 - The patch causes two unit test methods to fail. These should be able to
 be corrected with the `@expectedIncorrectUsage` tag.
 - I am a little hesitant to introduce a notice for every single menu with
 an integer slug. This could very quickly cause an error log to become
 large in size. Instead, how about the message is less specific (don't
 include the key), maybe "Strings should always be used for menu location
 slugs.", and let's only call `_doing_it_wrong()` for the first instance
 that is encountered (use a `break;`).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45361#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform