[wp-trac] [WordPress Trac] #46540: Admin bar CSS shouldn't be added in the customizer

WordPress Trac noreply at wordpress.org
Sun Mar 17 19:46:00 UTC 2019


#46540: Admin bar CSS shouldn't be added in the customizer
-------------------------------------+-----------------------------
 Reporter:  nabil_kadimi             |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.2
Component:  Customize                |     Version:  4.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  administration
-------------------------------------+-----------------------------
Changes (by dlh):

 * keywords:   => has-patch needs-testing
 * focuses:  ui, administration => administration
 * version:  5.1 => 4.5
 * milestone:  Awaiting Review => 5.2


Comment:

 Thanks for your report, @nabil_kadimi!

 This issue can be fixed, at least superficially, by including a
 `customize_messenger_channel` parameter in the selective-refresh request,
 which activates essentially the same logic in
 `\WP_Customize_Manager::setup_theme()` as in the workaround:
 https://github.com/WordPress/wordpress-
 develop/blob/6d2f78d9bacf931fb9d4ba031e135c4eb5b17713/src/wp-includes
 /class-wp-customize-manager.php#L559-L562

 However, I confess that I'm not sure what the `messenger_channel` is for
 or why it might have been excluded from the partial-refresh requests so
 far.

 @westonruter, are you able to comment on the merits of
 [attachment:"46540.diff"]?

 Also, @nabil_kadimi , what's the use case for a partial that includes
 `wp_head()`?

 I'm very gingerly adding this to the 5.2 milestone just in case the fix
 really is only to add the one line and could be easily shepherded into a
 release.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46540#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list