[wp-trac] [WordPress Trac] #46529: CSS line-height values should be unitless - media-views.css

[WordPress Trac]

#46529: CSS line-height values should be unitless - media-views.css
-------------------------------------+-------------------------------------
 Reporter:  ianbelanger              |       Owner:  ianbelanger
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  General                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, administration,
  good-first-bug                     |  coding-standards
-------------------------------------+-------------------------------------
Description changed by ianbelanger:

Old description:

> As outlined in #44643, CSS line-height values should be unitless `unless
> necessary to be defined as a specific pixel value`. It was suggested that
> we break up 44643 by stylesheet in order to better track them.
>
> This ticket covers much of `wp-admin/css/media-views.css`, see patch
> notes below
>
> Note: The patch was tested only on a Windows machine in Chrome, Firefox,
> IE11 and Edge. As per
> https://core.trac.wordpress.org/ticket/44643#comment:23 it should
> probably be tested on other OS's and supported browsers.
>
> **Patch Notes:**
>
> Unable to find selectors in the DOM. These may no longer exist in Core,
> but I am not 100% sure about that.
> {{{
> line 328 - .media-sidebar .sidebar-title
> line 1139 - .attachments-browser .instructions
> }}}

New description:

 As outlined in #44643, CSS line-height values should be unitless `unless
 necessary to be defined as a specific pixel value`. It was suggested that
 we break up 44643 by stylesheet in order to better track them.

 This ticket covers much of `wp-includes/css/media-views.css`, see patch
 notes below

 Note: The patch was tested only on a Windows machine in Chrome, Firefox,
 IE11 and Edge. As per
 https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably
 be tested on other OS's and supported browsers.

 **Patch Notes:**

 Unable to find selectors in the DOM. These may no longer exist in Core,
 but I am not 100% sure about that.
 {{{
 line 328 - .media-sidebar .sidebar-title
 line 1139 - .attachments-browser .instructions
 }}}

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46529#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform