[wp-trac] [WordPress Trac] #41074: Create new Dashicons (4.9)

[WordPress Trac]

#41074: Create new Dashicons (4.9)
-------------------------------------------------+-------------------------
 Reporter:  EmpireOfLight                        |       Owner:  netweb
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.2
Component:  Administration                       |     Version:  4.9
 Severity:  normal                               |  Resolution:
 Keywords:  needs-dev-note reporter-feedback     |     Focuses:  ui
  needs-refresh has-patch                        |
-------------------------------------------------+-------------------------

Comment (by Joen):

 > All the icons appear to be displaying correctly except .dashicons-
 instagram. I have uploaded a screenshot of this for review.

 That instagram icon looks like it wasn't fully "flattened". By making it a
 compound shape in Illustrator, i.e. single `path` in the SVG, it should
 probably go over fine.

 > Seems to be an oversight, not an intentional choice. Could we restore
 it?
 > Same for share1: added to codepoints.json in the commit linked above,
 but not to icon-font/dashicons.css. Seems to be an oversight as well.

 Almost certainly an oversight, and thank you for catching this.

 Just to clarify how things are _supposed_ to work.

 - `sources/svg` should include SVGs that are included in both icon font
 and React component
 - `sources/gutenberg` are not included in the icon font, these do not get
 codepoints, and are built only into the react component
 - `sources/svg-unused` are icons that existed in the past, but were never
 actually shipped

 Around codepoints.json, that file exists so that unicode locations for
 each icon the font persists across build processes. Many icon fonts rely
 solely on the CSS classname to reference an icon, and so it doesn't matter
 that the unicode location swaps places. That's obviously insufficient for
 the Dashicons font, which is why the codepoints.json file is referenced.

 As we moved to a build process from the old manually built system, there
 was a great deal of manual work in porting existing unicode locations from
 the manually built font, to the codepoints file. To put it simply, every
 icon that existed in the font before the build process had to have its
 unicode location converted to hexadecimal to be included in the JSON file.
 This is what I referenced in this comment here:
 https://core.trac.wordpress.org/ticket/41074#comment:37

 This is just to give some additional history and clarification. So it's
 entirely possible that icons that are supposed to be present in the
 codepoints file were forgotten due to human oversight. Thanks for helping
 catch these.

 It is worth noting, though, that as soon as we ship the icon font that's
 made from the build process, everything from that point on is automated,
 which should reduce the chance of such human error in the future.

 Hope that helps.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41074#comment:93>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform