[wp-trac] [WordPress Trac] #40662: Archive widget doesn't show the selected month name in the frontend widget itself

WordPress Trac noreply at wordpress.org
Thu Mar 7 18:01:40 UTC 2019


#40662: Archive widget doesn't  show the selected month name in the frontend widget
itself
-------------------------------------+-------------------------------------
 Reporter:  Themonic                 |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.2
Component:  Widgets                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  ui, accessibility,
  patch needs-dev-note needs-        |  javascript
  refresh                            |
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch needs-testing needs-dev-note => has-
     screenshots has-patch needs-dev-note needs-refresh


Comment:

 Noticed a couple things:

 1
 The patch needs some coding standards. Please run
 `phpcs --standard=phpcs.xml.dist src/wp-includes/general-template.php`

 and fix all the warning/errors marked with `[x]`

 2
 As a long-term goal, [https://core.trac.wordpress.org/ticket/40925 these
 selects shouldn't use the change event]. For now, there's the need to
 address a behavior that didn't matter before but is now relevant:
 - select a month
 - the page reloads displaying the correct month
 - select again the default option "Select Month"
 - the page reloads: this shouldn't happen
 - comparing with what the Categories select does, the JavaScript should be
 modernized a bit and not trigger a page reload when the default option is
 selected
 - this means the markup should be changed too, to wrap the select with a
 `<form>` element (see for inspiration the Categories widget)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40662#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list