[wp-trac] [WordPress Trac] #44005: Privacy template file

WordPress Trac noreply at wordpress.org
Thu Mar 7 09:57:59 UTC 2019


#44005: Privacy template file
-------------------------------------------------+-------------------------
 Reporter:  Clorith                              |       Owner:  garrett-
                                                 |  eclipse
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.2
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  needs-testing has-patch has-unit-    |     Focuses:  template,
  tests                                          |  privacy
-------------------------------------------------+-------------------------
Changes (by birgire):

 * keywords:  needs-testing needs-unit-tests has-patch => needs-testing has-
     patch has-unit-tests


Comment:

 [attachment:"44005-3.diff"] adds unit-tests for

 - the {{{is_privacy_policy()}}} template tag.
 - the {{{privacy-policy}}} body class.
 - the support of {{{privacy-policy.php}}} in the template hierarchy.

 I also adjusted:

 {{{Tests_Url_GetPrivacyPolicyUrl::test_get_privacy_policy_url_should_return_valid_url_when_policy_page_set()}}}

 to avoid mismatch between the expected {{{http://test.dev/test-dev-
 privacy-policy/}}} and actual {{{http://test.dev/?page_id=31}}} that
 surfaced when testing the patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44005#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list