[wp-trac] [WordPress Trac] #46698: Twenty Nineteen: use better color names for the editor palette

WordPress Trac noreply at wordpress.org
Mon Jun 24 18:20:06 UTC 2019


#46698: Twenty Nineteen: use better color names for the editor palette
---------------------------------------+--------------------------------
 Reporter:  afercia                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  5.3
Component:  Bundled Theme              |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  ui, accessibility
---------------------------------------+--------------------------------
Changes (by kjellr):

 * keywords:  has-screenshots needs-patch => has-screenshots has-patch


Comment:

 > Looking back at the above conversation, seems to me there's the need to
 check if setting null for custom colors triggers the Gutenberg fallback
 that produces a label like Color code: %s.

 Thank you for the clarification! I just tried it out and using `null` does
 revert to the color code. 🎉 I've attached a patch.

 Here are the labels when the default color is used:

 [[Image(https://cldup.com/MFXgHj76g5-3000x3000.png)]]
 [[Image(https://cldup.com/IunpjuKbTu-3000x3000.png)]]

 ... and when a custom color is chosen:

 [[Image(https://cldup.com/aWfXLqm4gI-3000x3000.png)]]
 [[Image(https://cldup.com/HYiRmQu2Jl-3000x3000.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46698#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list