[wp-trac] [WordPress Trac] #46946: Site Health: Text adjustment (add a link and remove "we")

WordPress Trac noreply at wordpress.org
Thu Jun 20 15:15:44 UTC 2019


#46946: Site Health: Text adjustment (add a link and remove "we")
------------------------------------------------+---------------------
 Reporter:  birgire                             |       Owner:  (none)
     Type:  enhancement                         |      Status:  new
 Priority:  normal                              |   Milestone:  5.3
Component:  Site Health                         |     Version:  5.2
 Severity:  normal                              |  Resolution:
 Keywords:  site-health has-patch dev-feedback  |     Focuses:
------------------------------------------------+---------------------

Comment (by tobifjellner):

 Replying to [comment:13 leogermani]:
 > In fact, I was wondering if instead of:
 >
 > ` printf( __('Here is my <a href="%s">link to the admin</a>'),
 admin_url() ); `
 >
 > We should have (with appropriate translators comment):
 >
 > ` printf( __('Here is my %1$slink to the admin%2$s'), '<a href="' .
 admin_url() . '">', '</a>' ); `
 >
 > This would take the burden of HTML out of the translators hand...

 Both ways are totally OK and we see both of them in various places in
 Core.
 But for version 2, it is critically important that a good explanation is
 given in a comment to translators. (Personally, I prefer number 1, but
 again: both ways are fully ok)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46946#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list