[wp-trac] [WordPress Trac] #47282: Use font-display for Google Fonts in core themes

WordPress Trac noreply at wordpress.org
Wed Jun 12 23:12:17 UTC 2019


#47282: Use font-display for Google Fonts in core themes
---------------------------+--------------------------
 Reporter:  westonruter    |       Owner:  westonruter
     Type:  enhancement    |      Status:  assigned
 Priority:  normal         |   Milestone:  5.3
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+--------------------------
Changes (by westonruter):

 * owner:  flixos90 => westonruter
 * status:  reopened => assigned


Comment:

 Good catch. The `+` is getting double-encoded. I'll commit this patch (as
 I need to dust off my commit!):


 {{{#!diff
 --- a/src/wp-content/themes/twentytwelve/functions.php
 +++ b/src/wp-content/themes/twentytwelve/functions.php
 @@ -165,7 +165,7 @@ function twentytwelve_get_font_url() {
                 }

                 $query_args = array(
 -                       'family'  => urlencode(
 'Open+Sans:400italic,700italic,400,700' ),
 +                       'family'  => urlencode( 'Open
 Sans:400italic,700italic,400,700' ),
                         'subset'  => urlencode( $subsets ),
                         'display' => urlencode( 'fallback' ),
                 );

 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47282#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list