[wp-trac] [WordPress Trac] #37684: Allow sites to have filterable "states" akin to posts & media

WordPress Trac noreply at wordpress.org
Wed Jun 5 16:12:50 UTC 2019


#37684: Allow sites to have filterable "states" akin to posts & media
-----------------------------------+------------------------------
 Reporter:  johnjamesjacoby        |       Owner:  johnjamesjacoby
     Type:  enhancement            |      Status:  assigned
 Priority:  normal                 |   Milestone:  5.3
Component:  Networks and Sites     |     Version:  3.0
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |     Focuses:  multisite
-----------------------------------+------------------------------

Comment (by pbiron):

 A couple other things I just came across while testing the patch on
 #37392:

 1. `WP_MS_Sites_List_Table::$status_list` does not contain 'Public', hence
 by default, `public` sites don't get a "site_state".  Of course, plugins
 could add that state with the new `display_site_states` filter, but I
 think it would be better handled in core by adding 'Public' to the
 `$status_list` array.

 2. with the addition of "views" for site statuses in #37392, I think it
 makes sense to have `site_states()` exclude a given "site_state when that
 state is the same as the current "view", just as `_post_states()` excludes
 **Pending** when the current "view" for `WP_Posts_List_Table` is
 "Pending".

 Any thoughts on those 2 points?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37684#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list