[wp-trac] [WordPress Trac] #40439: Save progress of intermediate image creation after upload

WordPress Trac noreply at wordpress.org
Wed Jun 5 02:16:13 UTC 2019


#40439: Save progress of intermediate image creation after upload
-------------------------------------------------+-------------------------
 Reporter:  mikeschroder                         |       Owner:
                                                 |  mikeschroder
     Type:  enhancement                          |      Status:  assigned
 Priority:  high                                 |   Milestone:  5.3
Component:  Media                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:  ui
  tests early                                    |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 In 40439.4.diff:
 - Take out the (test) UI including the ajax action, etc.
 - Clean up some function and var names, mark the functions non-private,
 add inline docs.
 - Review, improve, account for edge cases in
 `wp_get_missing_image_subsizes()`, `wp_get_defined_image_subsizes()`, and
 `wp_create_image_subsizes()`.
 - Fix the `$duplicate` test when creating new sub-size in both
 `WP_Image_Editor_Imagick` and `WP_Image_Editor_GD`. It only checks whether
 the just resized image matches the source image.
 - Add fallback when a plugin extends `WP_Image_Editor` and doesn't have
 the new `make_subsize()` method that returns the image meta value after
 each sub-size is created.

 There are also some unrelated WPCS fixes in the patch.

 This seems to work well here. Please get the testing plugin and give it a
 go :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40439#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list