[wp-trac] [WordPress Trac] #46529: CSS line-height values should be unitless - media-views.css

[WordPress Trac]

#46529: CSS line-height values should be unitless - media-views.css
-------------------------------------+-------------------------------------
 Reporter:  ianbelanger              |       Owner:  ianbelanger
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.3
Component:  Media                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, administration,
  good-first-bug                     |  coding-standards
-------------------------------------+-------------------------------------
Changes (by afercia):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 > line 328 - .media-sidebar .sidebar-title
 > line 1139 - .attachments-browser .instructions


 `.attachments-browser .instructions` is still used for the instructions
 that appear in the edit gallery view, edit playlist view, and for example
 in the Customizer when setting a header image. See attached screenshot.

 Re: `.media-sidebar .sidebar-title` after some software archeology, I
 think it's a leftover, as well as `sidebar-content` and `.media-sidebar
 .search` and these rules can be safely removed.

 They were introduced in [22321] for the first implementation of the media
 sidebar. Then removed right after in [22362]. Also, as far as I can tell
 there's no search in the sidebar.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46529#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform