[wp-trac] [WordPress Trac] #47783: PHP 7.4: Deprecations

[WordPress Trac]

#47783: PHP 7.4: Deprecations
--------------------------+------------------------------
 Reporter:  ayeshrajans   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by jrf):

 Reviewed `47783-magic_quotes_deprecation-wp-core.patch` and looks sane to
 me.

 `get_magic_quotes_gpc()` will always return `false` on PHP 5.4+, so
 removing the conditions related to this completely is the right course of
 action.

 ----

 Reviewed ` 47783-magic_quotes_deprecation-getid3.patch` and looks sane to
 me.

 ----

 Reviewed `47783-magic_quotes_deprecation-phpmailer.patch` and IMO, all
 references to magic quotes in the `encodeFile()` function can be removed
 as `get_magic_quotes_runtime()` will always return `false` on PHP 5.4+.
 I.e.:
 * The code line now touched + the whole condition block below it.
 * The condition block a few lines further down.

 PHPMailer currently has a
 [https://github.com/PHPMailer/PHPMailer/blob/master/composer.json#L23
 minimum PHP requirement] of PHP 5.5.0, so these changes can be safely
 made.

 ----

 Refs:
 * https://www.php.net/manual/en/function.get-magic-quotes-gpc.php
 * https://www.php.net/manual/en/function.get-magic-quotes-runtime.php
 * https://wiki.php.net/rfc/deprecations_php_7_4#magic_quotes_legacy

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47783#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform