[wp-trac] [WordPress Trac] #47599: Return for short circuits for multisite classes.

WordPress Trac noreply at wordpress.org
Tue Jul 23 20:42:00 UTC 2019


#47599: Return for short circuits for multisite classes.
--------------------------------+------------------------------
 Reporter:  spacedmonkey        |       Owner:  adamsilverstein
     Type:  defect (bug)        |      Status:  assigned
 Priority:  normal              |   Milestone:  5.3
Component:  Networks and Sites  |     Version:  5.2
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:  multisite
--------------------------------+------------------------------

Comment (by adamsilverstein):

 @spacedmonkey Thanks for the patch!

 Can you explain what problem this patch solves? are you still seeing
 database queries after returning an array of ids from this filter?

 noticing that after this patch we loose handling in
 https://github.com/WordPress/wordpress-develop/blob/master/src/wp-includes
 /class-wp-network-query.php#L247-L290 - including args like fields, count
 and update_network_cache.

 Also the function `get_networks` usually returns an array of `WP_Network`
 objects - after this change it looks more like you the function would
 return an array of IDs, is that right?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47599#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list