[wp-trac] [WordPress Trac] #47321: Show different fatal error message when in Recovery Mode and unable to redirect

WordPress Trac noreply at wordpress.org
Wed Jul 17 21:52:23 UTC 2019


#47321: Show different fatal error message when in Recovery Mode and unable to
redirect
-------------------------------------------------+-------------------------
 Reporter:  TimothyBlynJacobs                    |       Owner:  marybaum
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Site Health                          |     Version:  5.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch servehappy dev-feedback    |     Focuses:
  needs-unit-tests has-copy-review copy-         |
  approved                                       |
-------------------------------------------------+-------------------------

Comment (by garrett-eclipse):

 Awesome thanks @marybaum

 So to move this forward the only outstanding questions were;
 > Also should the two other strings found in the
 display_default_error_template function get some copy love as well to
 match the tone and conveyance of this string? They are;
 > } elseif ( is_protected_endpoint() ) {
 >         $message = __( 'The site is experiencing technical difficulties.
 Please check your site admin email inbox for instructions.' );
 > } else {
 >         $message = __( 'The site is experiencing technical
 difficulties.' );
 > }
 > Also adding 'needs-unit-tests' to account for @afragen's request;
 > Adding a simple test case for triggering these errors and testing the
 patch would be very helpful.

 @clorith / @afragen / @TimothyBlynJacobs do we want to make those two
 additional strings consistent with this new one? And does this actually
 need Unit Tests?
 Thanks

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47321#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list