[wp-trac] [WordPress Trac] #40030: Pass User and Comment Objects to rest_get_avatar_urls

[WordPress Trac]

#40030: Pass User and Comment Objects to rest_get_avatar_urls
--------------------------------------+-----------------------------
 Reporter:  dshanske                  |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.3
Component:  REST API                  |     Version:  4.7
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:10 pputzer]:
 > @donmhico's patch looks good to me, except that I think the parameter
 object should not be referred to as "the Gravatar". I know that's the
 wording from `get_avatar_url()`, but I think "The object to retrieve an
 avatar URL for." would be better to make it clear what the parameter
 actually is.

 Given that the `$id_or_email` parameter is described as "The Gravatar to
 retrieve a URL for"  in
 `get_avatar_url()`, `get_avatar_data()`, `get_avatar()`, and their
 respective filters, I'd rather do the same for consistency here.

 We could open a new ticket to change that description globally if
 necessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40030#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform