[wp-trac] [WordPress Trac] #47681: Critical error handler needs to offer backup troubleshooting instructions in addition to email

[WordPress Trac]

#47681: Critical error handler needs to offer backup troubleshooting instructions
in addition to email
-------------------------------------+---------------------
 Reporter:  tobifjellner             |       Owner:  (none)
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  5.3
Component:  Site Health              |     Version:  5.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------
Changes (by garrett-eclipse):

 * keywords:   => has-patch needs-testing


Comment:

 Hello, thanks for the initial patches @dkarfa & @hareesh-pillai

 I've uploaded
 [https://core.trac.wordpress.org/attachment/ticket/47681/47681.2.diff
 47681.2.diff] to address this issue by reusing the strings and link setup
 found in `class-wp-site-health.php`.

 I went this direction for a few reasons;
 - Doesn't introduce new strings.
 - Applies to both of the messages, original patch only applied to the
 `$message` when `is_protected_endpoint()`
 - Adds the external link icon, security noopener and accessibility text
 - Uses string placeholders properly with sprintf the original patches had
 placeholders but no printf function to apply them.
 - Drops the repetitive `debugging instructions` as it was twice in the
 second patch; once before the link and the second as the link text.

 Please review & test. Thanks

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47681#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform