[wp-trac] [WordPress Trac] #46125: No cache cleanup after populate_options action call

WordPress Trac noreply at wordpress.org
Thu Jan 31 12:08:12 UTC 2019


#46125: No cache cleanup after populate_options action call
--------------------------------+------------------------
 Reporter:  david.binda         |       Owner:  (none)
     Type:  defect (bug)        |      Status:  new
 Priority:  normal              |   Milestone:  5.1
Component:  Networks and Sites  |     Version:  trunk
 Severity:  normal              |  Resolution:
 Keywords:                      |     Focuses:  multisite
--------------------------------+------------------------

Comment (by spacedmonkey):

 Thanks for the ticket here @davidbinda .

 Have you got an example code where we can see the break?

 As for the patch couple bit of feedback.

 1. `clean_blog_cache( get_current_blog_id() );` should be
 `clean_blog_cache( $site );`. We have the site object to hand, we should
 use it.
 2. A factory should be used to create the test site, some should look this
 `$factory->blog->create( $id );`
 3. Instead of `update_option` use `update_blog_option`
 4. Needs doc blocks and comments on all doc.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46125#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list