[wp-trac] [WordPress Trac] #45950: Twenty Nineteen: Fix social media icons to use the correct height & width attribute

WordPress Trac noreply at wordpress.org
Wed Jan 23 19:40:53 UTC 2019


#45950: Twenty Nineteen: Fix social media icons to use the correct height & width
attribute
---------------------------+------------------------------
 Reporter:  crunnells      |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  5.0.3
 Severity:  normal         |  Resolution:
 Keywords:  2nd-opinion    |     Focuses:
---------------------------+------------------------------
Changes (by laurelfulford):

 * keywords:   => 2nd-opinion


Comment:

 Thanks @mukesh27 and @crunnells!

 Just to make sure: @allancole or @kjellr, was the smaller size (`24` or
 `26`) meant to override anything in the social menu? As Chris pointed out,
 the CSS is setting the actual size (`32`); I agree that switching it to
 `32` in the code as well makes sense if that's the intended display size.
 I just want to make sure I'm not missing something here - thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45950#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list