[wp-trac] [WordPress Trac] #45974: wp_maintenance should use wp_die

[WordPress Trac]

#45974: wp_maintenance should use wp_die
----------------------------+---------------------
 Reporter:  spacedmonkey    |       Owner:  (none)
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  5.2
Component:  Bootstrap/Load  |     Version:  3.0
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+---------------------
Changes (by spacedmonkey):

 * milestone:  Awaiting Review => 5.2


Comment:

 In 5.1 `wp_die` received a number of improvements ( #45933 #46026 #46054
 #46025 ). So using `wp_die` add the following improvements here.

 - Errors will be displayed in the correct format depending on the request,
 so xml, json, jsonp, xmlrpc and ajax request, will get the correctly
 formatted response.
 - WP_CLI would be able to use as @pento mentions above.
 - Error messages will be styled on look consistent with the rest of core.
 - Future improvements to `wp_die` will be reflected in the maintenance
 mode.
 - Correct cache control headers will be sent. (See #46054 )
 - As json request now handles better (see #45933), it means anything use
 REST API will error my gracefully (including Gutenberg).

 The arguments can made for these tickets. #41655 #45975

 I am making this as 5.2, in the hopes that is goes in.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45974#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform