[wp-trac] [WordPress Trac] #43151: Media widgets shouldn't use a clickable div as an UI control

WordPress Trac noreply at wordpress.org
Thu Jan 17 14:51:17 UTC 2019


#43151: Media widgets shouldn't use a clickable div as an UI control
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.2
Component:  Widgets                  |     Version:  4.8
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots needs-   |     Focuses:  ui, accessibility,
  testing has-patch                  |  javascript
-------------------------------------+-------------------------------------

Comment (by afercia):

 Thanks @welcher and @ramonopoly ! Yep, not a big issue but it would be
 nice to use a different name for the CSS class. Also, quickly testing:

 - the button needs a focus style otherwise the browsers native focus style
 will be used:

 [[Image(http://cldup.com/1YtkyCKBRU.png)]]


 - it needs a focus stile for Windows High Contrast mode as well, see
 https://core.trac.wordpress.org/changeset/44544
 - when clicking the button, its text color becomes white on Safari: the
 `:active` state needs to be styled
 - instead of the colors `#edeff0` and `#f8f9f9`, it would be nice to use
 the closest colors from the official WP palette, see
 https://make.wordpress.org/design/handbook/design-
 guide/foundations/colors/ and https://codepen.io/hugobaeta/full/RNOzoV/

 Will refresh the patch.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43151#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list