[wp-trac] [WordPress Trac] #44736: Comment cookies are completely disabled when "Show comments cookies opt-in checkbox" is not enabled

[WordPress Trac]

#44736: Comment cookies are completely disabled when "Show comments cookies opt-in
checkbox" is not enabled
-------------------------------------+----------------------
 Reporter:  pputzer                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.1
Component:  Comments                 |     Version:  4.9.8
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  privacy
-------------------------------------+----------------------

Comment (by pputzer):

 Replying to [comment:26 dhavalkasvala]:
 >
 > So find solution complete disable cookies solution pls can tell me for
 that is it right change or not?

 I just re-read your patch [attachment:"#44736.patch"] and I think it is
 actually not doing the right thing - so @desrosj's patch
 [attachment:"44736.diff"] of course behaves differently. I'll try to
 clarify this:

 * **Status quo**: if `show_comments_cookies_opt_in` is not set, no cookies
 are set (because `$cookies_consent` is false). Existing cookies are
 deleted.
 * **@dhavalkasvala's proposed patch**:  if `show_comments_cookies_opt_in`
 is not set, no cookies are set (because `$cookies_consent` is false).
 Existing cookies are deleted in this case. However, if
 `show_comments_cookies_opt_in` is set, but no consent was given, existing
 cookies are __not__ deleted anymore. (IMHO, that's wrong on both points.)
 * **My suggestion/@desroj's patch**: if `show_comments_cookies_opt_in` is
 not set, consent (or necessity) is implied and `$cookies_consent` things
 work like they did before 4.9.6 introduced the `cookies` checkbox.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44736#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform