[wp-trac] [WordPress Trac] #45934: Coding Standards: Manual Fixes

[WordPress Trac]

#45934: Coding Standards: Manual Fixes
----------------------------+-------------------------------
 Reporter:  pento           |       Owner:  pento
     Type:  task (blessed)  |      Status:  assigned
 Priority:  low             |   Milestone:  5.1
Component:  General         |     Version:
 Severity:  minor           |  Resolution:
 Keywords:                  |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by jrf):

 @pento Reviewed. This is currently (aside from whitelist comments) the
 right way to do this.

 I presume you are concerned that using the properties would accidentally
 whitelist too much ?

 I'd been thinking about this before and have been playing with the thought
 of adding scoping to this property.
 Elements in an property array can have keys, i.e. `<element
 key="something" value="something"/>`, though the sniff currently only
 expects and looks at values.

 We could use the key to limit the whitelisting for a particular property
 to a specific file/folder or class.

 I'm not sure (yet) what would be the best identifier to use. Input
 welcome. (and yes, one of us should probably open an issue about this in
 the WPCS repo).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45934#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform