[wp-trac] [WordPress Trac] #45679: Bundled Themes: Bump script and style version numbers

WordPress Trac noreply at wordpress.org
Wed Jan 2 17:58:25 UTC 2019


#45679: Bundled Themes: Bump script and style version numbers
--------------------------------------------+----------------------------
 Reporter:  laurelfulford                   |       Owner:  laurelfulford
     Type:  defect (bug)                    |      Status:  assigned
 Priority:  normal                          |   Milestone:  5.0.3
Component:  Bundled Theme                   |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch needs-testing commit  |     Focuses:
--------------------------------------------+----------------------------

Old description:

> When existing scripts or styles are updated in default themes, the
> version numbers in the enqueues should also be bumped to make sure the
> old files don't cache.
>
> This was missed in a Twenty Sixteen update in 5.0, as well as some
> upcoming updates slated for 5.0.2. Specifically:
>
> Twenty Seventeen
> * style.css (#44699)
> * editor-blocks.css (#45452, #45408)
>
> Twenty Sixteen
> * functions.js (#45380)
> * blocks.css (#45427)
>
> Twenty Fifteen
> * blocks.css (#45428)
>
> Twenty Fourteen
> * blocks.css (#45429)
>
> Twenty Thirteen
> * blocks.css & editor-blocks.css (#45431)
>
> Twenty Twelve
> * blocks.css (#45432)
> * editor-blocks (#45432, #45452)
>
> Twenty Eleven
> * blocks.css (#45433)
> * editor-blocks.css (#45421)
>
> Twenty Ten
> * blocks.css (#45434)
>
> (Thanks to @SergeyBiryukov for catching this
> [https://core.trac.wordpress.org/ticket/45380#comment:8 here]!)

New description:

 When existing scripts or styles are updated in default themes, the version
 numbers in the enqueues should also be bumped to make sure the old files
 don't cache.

 This was missed in a Twenty Sixteen update in 5.0, as well as some
 upcoming updates slated for 5.0.2. Specifically:

 Twenty Seventeen
 * style.css (#44699)
 * editor-blocks.css (#45452, #45408)

 Twenty Sixteen
 * functions.js (#45380)
 * blocks.css (#45427)

 Twenty Fifteen
 * blocks.css (#45428)

 Twenty Fourteen
 * blocks.css (#45429)

 Twenty Thirteen
 * blocks.css & editor-blocks.css (#45431)

 Twenty Twelve
 * blocks.css (#45432)
 * editor-blocks (#45432, #45452)

 Twenty Eleven
 * blocks.css (#45433)
 * editor-blocks.css (#45421)

 (Thanks to @SergeyBiryukov for catching this
 [https://core.trac.wordpress.org/ticket/45380#comment:8 here]!)

--

Comment (by laurelfulford):

 Thank you for the review, @netweb!

 I belatedly realized that this is the only update currently slated for
 Twenty Ten for 5.0.3, and it's quite minor for a whole new version of a
 theme. The CSS change the version bump is meant to cover is also pretty
 small (#45434).

 I'm going to skip committing that theme's functions.php for now, and
 handle it in a future release of Twenty Ten where there are more changes.

 I've updated the ticket description above to remove it from the list.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45679#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list