[wp-trac] [WordPress Trac] #43170: Replace all usages of basename() with wp_basename() in order to support multibyte filenames

WordPress Trac noreply at wordpress.org
Mon Feb 25 15:47:03 UTC 2019


#43170: Replace all usages of basename() with wp_basename() in order to support
multibyte filenames
-----------------------------+---------------------
 Reporter:  Viper007Bond     |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  5.2
Component:  Media            |     Version:  4.9.2
 Severity:  normal           |  Resolution:
 Keywords:  has-patch early  |     Focuses:
-----------------------------+---------------------

Comment (by joemcgill):

 Thanks for the suggestion, @Viper007Bond and @jorbin for the new patch,
 which looks good to me. The only nitpick I have is that this includes
 several changes to docblocks where we're referring to something like a
 "file basename" and changing it to "wp_basename" seems to mix
 implementation details with the descriptive noun "basename" we're trying
 to retrieve.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43170#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list