[wp-trac] [WordPress Trac] #45795: Twenty Nineteen: missing license information for assets

WordPress Trac noreply at wordpress.org
Mon Feb 25 12:49:59 UTC 2019


#45795: Twenty Nineteen: missing license information for assets
---------------------------+----------------------------
 Reporter:  poena          |       Owner:  williampatton
     Type:  enhancement    |      Status:  assigned
 Priority:  high           |   Milestone:  5.2
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:
---------------------------+----------------------------

Comment (by kjellr):

 Thanks, @poena — aside from Material icons, there are two other types of
 icons bundled in the theme:

 **Custom Icons**

 I think there's only one of these, and it was made by me. It lives here:

 https://github.com/WordPress/twentynineteen/blob/7eebe8f48b5c51e64b229052f5e357f28fb873ea/classes
 /class-twentynineteen-svg-icons.php#L163-L169

 I believe this icon was ultimately unused though. I'll double check and if
 that's the case, I'll get a patch going to eliminate it if so.

 **Social icons**

 These were included following the precedent of the social media logos
 included in Twenty Seventeen:

 https://raw.githubusercontent.com/WordPress/twentyseventeen/master/assets/images
 /svg-icons.svg

 I'm not sure of the origins of the Twenty Seventeen ones, but my
 understanding is that the initial set in Twenty Nineteen was sourced from
 here:

 https://github.com/Automattic/social-logos

 This was before I was involved with the theme though, so perhaps
 @allancole can confirm.

 From a quick look through the GitHub history, it looks like the last.fm
 icon you linked to is the only brand new social icon addition since the
 initial commit of those icons. (Other PRs simply updated the icon > URL
 mapping).

 https://github.com/WordPress/twentynineteen/commit/970dd7368d1d035452b62646bcef739b504d7d73
 #diff-345c080c95a164e6ab1651e1020602a7

 If/when we have clarity around the appropriate license language and/or
 changes that need to happen. I'm happy to create the patch for us.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45795#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list