[wp-trac] [WordPress Trac] #46320: Replace http with https in the link placeholder widget image

WordPress Trac noreply at wordpress.org
Fri Feb 22 15:00:23 UTC 2019


#46320: Replace http with https in the link placeholder widget image
---------------------------------------+------------------------------
 Reporter:  Chaton666                  |       Owner:  audrasjb
     Type:  enhancement                |      Status:  reviewing
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  Widgets                    |     Version:  5.1
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  administration
---------------------------------------+------------------------------
Changes (by audrasjb):

 * owner:  (none) => audrasjb
 * status:  new => reviewing


Comment:

 Hi @Chaton666 and welcome to WordPress Trac

 Thanks for the patch and for the screenshots.

 The existing placeholder can make think that the user must use http. We
 should encourage the use of https.
 Also, the block editor uses https for its placeholders. Let's add some
 consistency.

 The patch looks good at a glance, but we should consider to not use a
 `value` attribute but a `placeholder`. ( Related: #46312 see @afercia 's
 comment)

 Related: #46312

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46320#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list