[wp-trac] [WordPress Trac] #44643: CSS line-height values should be unitless unless necessary to be defined as a specific pixel value

WordPress Trac noreply at wordpress.org
Wed Feb 13 18:34:55 UTC 2019


#44643: CSS line-height values should be unitless unless necessary to be defined as
a specific pixel value
-------------------------------------+-------------------------------------
 Reporter:  pbiron                   |       Owner:  ianbelanger
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  Future Release
Component:  General                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  needs-patch needs-dev-   |     Focuses:  ui, administration,
  note needs-testing                 |  coding-standards
-------------------------------------+-------------------------------------
Changes (by ianbelanger):

 * keywords:  needs-patch needs-dev-note => needs-patch needs-dev-note
     needs-testing


Comment:

 **Updated** notes for the 44643.1.common.css.diff patch

 In `/wp-admin/css/common.css`

 Unchanged line-height values that use units (I could not find a good
 unitless solution that would work across all browsers and admin pages)
 {{{
 line 222 - body
 line 509 - .widefat td, .widefat td p, .widefat td ol, .widefat td ul
 line 516 - .widefat th, .widefat thead td, .widefat tfoot td
 line 759 - .widget .widget-top, .postbox .hndle, .stuffbox .hndle,
 .control-section .accordion-section-title, .sidebar-name, #nav-menu-
 header, #nav-menu-footer, .menu-item-handle, .checkbox, .side-info, #your-
 profile #rich_editing, .widefat thead th, .widefat thead td, .widefat
 tfoot th, .widefat tfoot td
 }}}

 Still unable to find these selectors in the DOM
 {{{
 line 838 - .key-labels label
 line 1739 - .toggle-arrow
 line 1769 - #number-of-columns
 line 3040 - .bulk-action-notice .toggle-indicator:before
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44643#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list