[wp-trac] [WordPress Trac] #40333: TwentySeventeen: customize-controls.js passes unused jQuery argument to an IIFE that accepts no arguments

WordPress Trac noreply at wordpress.org
Sat Aug 31 01:08:54 UTC 2019


#40333: TwentySeventeen: customize-controls.js passes unused jQuery argument to an
IIFE that accepts no arguments
---------------------------+-----------------------------
 Reporter:  Christian1012  |       Owner:  SergeyBiryukov
     Type:  defect (bug)   |      Status:  reviewing
 Priority:  normal         |   Milestone:  5.3
Component:  Bundled Theme  |     Version:  4.7
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  javascript
---------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Hi @Christian1012, welcome to WordPress Trac!

 Thanks for the ticket and the patch! Sorry it took so long for someone to
 get back to you.

 Looks like this was done for consistency with other files (where `$` is
 used), or maybe as a copy/paste from those files. I have no objections to
 changing it though.

 The same should be done for Twenty Nineteen's `customize-controls.js` as
 well.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40333#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list