[wp-trac] [WordPress Trac] #47580: Prevent output of invalid HTML in `_default_wp_die_handler()`

WordPress Trac noreply at wordpress.org
Fri Aug 30 16:37:17 UTC 2019


#47580: Prevent output of invalid HTML in `_default_wp_die_handler()`
--------------------------------------+----------------------------
 Reporter:  jeremyfelt                |       Owner:  audrasjb
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  5.3
Component:  Administration            |     Version:
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch needs-dev-note  |     Focuses:  accessibility
--------------------------------------+----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:17 dinhtungdu]:
 > IMO, we don't need to keep them consistent in the future, they are two
 separated elements. We have their CSS rules identical for now because I
 want to keep the style as it was. In the future, it's more likely that
 we'll change the style for `.wp-die-message`.

 It just seems inconsistent to me that they're [source:trunk/src/wp-
 includes/functions.php?rev=45914&marks=3275-3280#L3272 combined in
 _default_wp_die_handler() styles], but separated in `common.css`. I would
 think it's better to reduce duplication for now and separate them in the
 future if needed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47580#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list