[wp-trac] [WordPress Trac] #47843: Update the WordPress Packages to the ones used in the Gutenberg 6.4 release

WordPress Trac noreply at wordpress.org
Fri Aug 30 06:09:23 UTC 2019


#47843: Update the WordPress Packages to the ones used in the Gutenberg 6.4 release
--------------------------+---------------------
 Reporter:  gziolo        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.3
Component:  Editor        |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+---------------------

Comment (by netweb):

 Any particular reason to change the `jquery` URL format in `package.json`
 in [attachment:"patch-6.4.diff"] ?

 {{{
 #!diff
         "jquery-color": "https://github.com/jquery/jquery-
 color/archive/2.1.1.tar.gz",
 110     110                     "jquery-form": "4.2.1",
 111     111                     "jquery-hoverintent": "1.8.3",
 112                             "jquery-ui": "https://github.com/jquery
 /jquery-ui/archive/1.11.4.tar.gz",
         112                     "jquery-ui": "github:jquery/jquery-
 ui#1.11.4",
 }}}

 It switches from an archived version to a commit hash
 {{{#!diff

                 "jquery-ui": {
 13836                                   "version":
 "https://github.com/jquery/jquery-ui/archive/1.11.4.tar.gz",
 13837                                   "integrity":
 "sha512-yMLXNruSte8iAAOsShJvUdcwgrHbWrxBCoKfPGqDmgFkfNLbnXoHcyxgOvI2IbgfupFF2paOm0AvOq6iERedKQ=="
         14110                           "version": "github:jquery/jquery-
 ui#d6713024e16de90ea71dc0544ba34e1df01b4d8a",
         14111                           "from": "github:jquery/jquery-
 ui#1.11.4"
 }}}

 I doubt there would be any issues so long as the commit hash matches the
 version expected.

 I'd rather see this change not be included though, and keep the original
 format unless I'm missing some reason to switch the URL to that proposed,
 if there is another underlying reason then the other packages using a
 ''pinned'' version such as `jquery-color` should probably also be updated
 to the same format for consistency etc.

 ----

 Also wondering if npm v6.11.0 should be used to avoid the 6.11.1 & 6.11.2
 bugs noticed in:
 > https://npm.community/t/6-11-1-some-dependencies-are-no-longer-being-
 installed/9586/5

 npm 6.11.3 is scheduled to include a fix for the above next Tuesday 3rd
 September
 > https://npm.community/t/release-6-11-2/9637/3?u=netweb

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47843#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list