[wp-trac] [WordPress Trac] #42251: Cache not found values for sites and network lookups by ID

WordPress Trac noreply at wordpress.org
Thu Aug 29 17:04:40 UTC 2019


#42251: Cache not found values for sites and network lookups by ID
---------------------------------------------+------------------------
 Reporter:  flixos90                         |       Owner:  flixos90
     Type:  enhancement                      |      Status:  closed
 Priority:  normal                           |   Milestone:  5.3
Component:  Networks and Sites               |     Version:
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit  |     Focuses:  multisite
---------------------------------------------+------------------------

Comment (by johnjamesjacoby):

 I’m concerned that the `-1` return value might get ran through `absint()`
 somewhere and become a `1` which would be really bad, because that is
 typically the ID for the main site in the main network.

 I don’t have a better idea though, and I don't have any evidence that this
 is an actual problem.

 `0` or `false` maybe… since site ID `0` will never exist?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42251#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list