[wp-trac] [WordPress Trac] #47369: Admin pages have two viewport meta tags on mobile

[WordPress Trac]

#47369: Admin pages have two viewport meta tags on mobile
----------------------------+---------------------
 Reporter:  BettyJJ         |       Owner:  (none)
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  5.3
Component:  Administration  |     Version:  3.3
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+---------------------
Changes (by talldanwp):

 * keywords:  has-patch => needs-patch


Comment:

 Hi @msaggiorato, thanks for working on this. The ticket was discussed in
 the core triage session (slack logs available in the link above).

 The patch worked well in testing. There were a few separate improvements
 to the code that were recommended which I'll summarise:

 - Small improvements to the if statement in `wp_admin_viewport_meta`, it
 was recommended that this is flipped to ` if ( empty( $viewport_meta ) )`
 and an early return used, so that there's less indentation.
 - The id on the viewport tag (originally added in [18926]) doesn't seem to
 be in use any more and it looks like it can be removed.
 - Documentation needs to be added for the for the
 `wp_admin_viewport_meta()` and `_customizer_mobile_viewport_meta()`
 functions, as well as the `admin_viewport_meta` filter.

 Thanks!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47369#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform