[wp-trac] [WordPress Trac] #47140: Twenty Nineteen: Improve the special pages headings

[WordPress Trac]

#47140: Twenty Nineteen: Improve the special pages headings
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  kjellr
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3
Component:  Bundled Theme                        |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch needs-     |     Focuses:
  testing                                        |  accessibility
-------------------------------------------------+-------------------------

Comment (by kjellr):

 > @kjellr what should I be expecting to see when searching for an empty
 string?

 What you're seeing above is about what I'd expect. Generally if you search
 for an empty string WordPress will just return all posts. Here are some
 examples from previous themes:

 https://twentyseventeendemo.wordpress.com/?s=
 https://twentysixteendemo.wordpress.com/?s=

 Style-wise though, I do believe that after this patch is applied, that
 extra period appended to the search query should disappear (It took me a
 couple hard refreshes to inherit the new styles):

 [[Image(https://cldup.com/rVnakOL_Rs.png)]]

 ----

 The main things to look for after applying this patch are:

 **Search Results Page**

 Ensure that the entire heading `Search results for: %searchterm%` is
 wrapped in a single `<h1>` tag.

 **Search Results Page (With no results)**

 The heading should be properly aligned.

 Before: [attachment:"02 Twenty Nineteen no search results heading.png"]
 After: [attachment:"47140-search-no-results-after-patch.PNG"]

 **404 Page**

 Ensure that the heading is properly aligned.

 Before: [attachment:"03 Twenty Nineteen 404 page heading.png"]
 After: [attachment:"47140-no-content-after-patch.PNG"]

 **Archive Pages**

 Ensure that the entire heading (eg. `Yearly archives: 2019`) is wrapped in
 a single `<h1>` tag. And that the space between the heading and the posts
 is consistent with the spacing on the search results page.

 Before: [attachment:"04 Twenty Nineteen archives heading.png"]
 After: [attachment:"47140-archive-after-patch.PNG"]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47140#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform