[wp-trac] [WordPress Trac] #47498: Revise checkbox/radio button css for better compatibility with text zoom

WordPress Trac noreply at wordpress.org
Mon Aug 26 19:08:09 UTC 2019


#47498: Revise checkbox/radio button css for better compatibility with text zoom
-------------------------------------------------+-------------------------
 Reporter:  kjellr                               |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch wpcampus-report form-      |     Focuses:  ui,
  controls color-contrast                        |  accessibility
-------------------------------------------------+-------------------------

Comment (by kjellr):

 > If that's the case, wouldn't be better to use rem?

 Yeah, good call. I've added [attachment:"47498.3.diff"], which makes that
 change. It also changes the small-screen values to `rem`, which I missed
 the first time around.

 One small note:

 There's still a padding rule that uses `px`, but I think it's actually
 totally unused?
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/css/forms.css#L1264

 It appears to be overridden by the `!important` above:
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/css/forms.css#L83

 If that's truly unused, I'd say we just delete it, rather than covert it
 over to `rem`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47498#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list