[wp-trac] [WordPress Trac] #43524: Add another default image size

WordPress Trac noreply at wordpress.org
Mon Aug 26 00:17:27 UTC 2019


#43524: Add another default image size
-----------------------------------+------------------------
 Reporter:  azaozz                 |       Owner:  joemcgill
     Type:  enhancement            |      Status:  assigned
 Priority:  normal                 |   Milestone:  5.3
Component:  Media                  |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+------------------------

Comment (by azaozz):

 Replying to [comment:24 pierlo]:

 @pierlo Thanks for the patch! While reviewing it was thinking why we store
 all these sizes in options and what happens when they get changed...
 Frankly I think this is a "left over" thing from 2003 :) There is no
 longer a good reason to have different images with different sub-sizes
 with the same sub-size name. It's just confusing and may result in
 generating poor srcset attribute.

 Also thinking we should remove the UI for setting of the three "classic"
 image sizes: thumbnail, medium, large. Currently a user can set a
 thumbnail to be 1000x1000px and "large" to be 50x50px...

 > `$max_srcset_image_width` is at 2624px. I'm not sure how the previous
 1600px was calculated.

 Yeah, the 1600px value was (mostly) arbitrary, based on current usage.
 Wondering how you came up with 2624px though. Is that some sort of a
 standard width somewhere on the internet?

 In 43524.2.patch I've changed that to `2560`. Thinking to use the same
 value for the "BIG" image cut-out size, see #47873. But lets set it to
 something that truly makes sense :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43524#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list