[wp-trac] [WordPress Trac] #47612: Media modal: implement a default title for the modal H1 heading

WordPress Trac noreply at wordpress.org
Fri Aug 23 13:32:51 UTC 2019


#47612: Media modal: implement a default title for the modal H1 heading
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.3
Component:  Media                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots has-     |     Focuses:  accessibility,
  patch                              |  javascript
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch commit => has-screenshots has-patch


Comment:

 @audrasjb @donmhico thanks! [attachment:"47612.diff"] looks good.

 I'd only consider to use a more generic title. Custom media frames could
 be used for anything, not necessarily to "Add Media". That's just one
 specific workflow amongst all the possible ones. Maybe just a simpler
 string `Media`? The new string should be added to the l10n object.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47612#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list