[wp-trac] [WordPress Trac] #35776: Installation pages do not have forms.css enqueued

WordPress Trac noreply at wordpress.org
Tue Aug 20 20:41:27 UTC 2019


#35776: Installation pages do not have forms.css enqueued
--------------------------------------+-----------------------------
 Reporter:  iseulde                   |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  5.3
Component:  Upgrade/Install           |     Version:
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  good-first-bug has-patch  |     Focuses:  ui
--------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:14 JeffPaul]:
 > looks like the prop in r45673 and r45844 should have been to
 `danmicamediacom`.

 Thanks for bringing that up!

 Previously, the rule of thumb was to always use the name that Trac shows:
 https://wordpress.slack.com/archives/C18723MQ8/p1471699137000226

 However, there are indeed some quirks when the username has spaces or is
 an email address:
 https://wordpress.slack.com/archives/C18723MQ8/p1513306349000049

 So apparently `user_nicename` should be used instead, but it's not
 currently available for Trac templates.

 I'll double check the correct username when updating the Credits API for
 5.2.3.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/35776#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list