[wp-trac] [WordPress Trac] #47428: Site Health: Remove duplicate code in VCS test

[WordPress Trac]

#47428: Site Health: Remove duplicate code in VCS test
--------------------------+-----------------------------
 Reporter:  desrosj       |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Site Health   |     Version:  5.2
 Severity:  normal        |  Resolution:
 Keywords:  site-health   |     Focuses:
--------------------------+-----------------------------

Comment (by Clorith):

 Avoiding duplication here would definitely be ideal, I'm not sure how we
 should approach the file/folder declarations though, as I view them as
 quite vital in the Site Health Check context, while it doesn't matter what
 is under VCS for `WP_Upgrader`.

 Any thoughts on the best approach here?

 Perhaps if `WP_Upgrader::is_vcs_checkout()` detects it being under version
 control, we can do a scan for `.svn`, `.git`, `.hg` and `.bzr` and pick up
 on their locations, `RecursiveDirectoryIterator` should be fast enough
 when given a rigid pattern like that to work with?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47428#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform