[wp-trac] [WordPress Trac] #47693: customizer Color picker should get closed when click on color picker area.

WordPress Trac noreply at wordpress.org
Fri Aug 2 17:04:22 UTC 2019


#47693: customizer Color picker should get closed when click on color picker area.
-------------------------------------+-------------------------------------
 Reporter:  monikarao                |       Owner:  afercia
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.3
Component:  Customize                |     Version:  4.9
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  accessibility,
  screenshots                        |  administration
-------------------------------------+-------------------------------------
Changes (by afercia):

 * keywords:  needs-patch => has-patch has-screenshots
 * owner:  (none) => afercia
 * focuses:  accessibility, javascript, administration => accessibility,
     administration
 * version:  5.2.2 => 4.9
 * milestone:  Awaiting Review => 5.3


Comment:

 There's some JavaScript
 [https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/lib/color-
 picker.js?rev=43347&marks=220-231#L219 to avoid the color picker closes
 when clicking within its container] so this part is necessary.

 However, the container shouldn't extend on the right edge. Instead, it
 should adapt its width to the color picker actual width. This appears to
 happen because of a typo introduced in [41329]: there's no element with a
 CSS class `wp-picker-containers` (note the `s` at the end). The selector
 in the `color-picker.css` stylesheet should be `wp-picker-container` so to
 apply `display: inline-block;` to the container.

 [attachment:"47693.diff"] solves the problem for the area on the right.
 I'd tend to think clicking the area at the top (between the buttons /
 input field and the color picker) should still not close the picker.
 There's a very high chance for unintentional clicks on that crowded UI
 section and preventing inaccurate clicks from closing the picker seems the
 best option.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47693#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list