[wp-trac] [WordPress Trac] #45800: Add short circuits for WP_Comment_Query

WordPress Trac noreply at wordpress.org
Thu Aug 1 20:42:31 UTC 2019


#45800: Add short circuits for WP_Comment_Query
-------------------------------------------------+-------------------------
 Reporter:  spacedmonkey                         |       Owner:
                                                 |  adamsilverstein
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.3
Component:  Comments                             |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by boonebgorges):

 Thanks for continuing to work on this, @adamsilverstein.

 The pattern in [attachment:"45800.4.diff"] is similar to the other query
 short-circuit filters, and those filters similarly require the client to
 follow the proper protocol regarding return values, count_total, etc. So I
 think it's fine to repeat the pattern here. In the dev note, it's probably
 worth showing an example, and then underscoring that this pattern applies
 to all similar queries.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45800#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list