[wp-trac] [WordPress Trac] #46901: 5.2 About Page

WordPress Trac noreply at wordpress.org
Tue Apr 30 08:42:35 UTC 2019

#46901: 5.2 About Page
 Reporter:  desrosj                    |       Owner:  karmatosed
     Type:  task (blessed)             |      Status:  assigned
 Priority:  normal                     |   Milestone:  5.2
Component:  Help/About                 |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:

Comment (by afercia):

 @SergeyBiryukov [attachment:"46901-tabs.3.diff"] fixes the tabs in the
 "About" pages but also changes the tabs in Appearance > Menus, on the
 multisite pages, or the ones used by plugins. Also, I'm not sure there's
 the need for some of the changes there, unless I'm missing something:
 - not sure there's the need to add `.about-wrap nav` to `.about-wrap h2
 {}` in about.css, as those CSS properties either don't apply to the tabs
 links or are overridden by other rules
 - `line-height: 1.33333333;`: while this fixes the tabs in the About page,
 it makes the other tabs smaller. This `line-height` needs to be the
 equivalent to `24px` with any font-size
 - not sure there's the need for `.wrap nav.nav-tab-wrapper` as there's
 already `.nav-tab-wrapper`
 - not sure there's the need for higher specificity for `.wrap nav .nav-
 - we should re-add the fix for the bottom border: the rule should override
 the white border for hover / focus / focus:active.

 I've tried to address these points in [attachment:"46901-tabs.4.diff"]. I
 guess at this point of the release cycle we should try to be very
 conservative and change only what needs to be changed. Some testing would
 be nice :) When testing, please check also the tabs in Appearance > Menus
 and tabs added by plugins, for example Yoast SEO, comparing with the tabs
 in WordPress 5.1.

Ticket URL: <https://core.trac.wordpress.org/ticket/46901#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list