[wp-trac] [WordPress Trac] #46698: Twenty Nineteen: use better color names for the editor palette

WordPress Trac noreply at wordpress.org
Tue Apr 30 07:05:55 UTC 2019


#46698: Twenty Nineteen: use better color names for the editor palette
-----------------------------------------+--------------------------------
 Reporter:  afercia                      |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  5.3
Component:  Bundled Theme                |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-screenshots needs-patch  |     Focuses:  ui, accessibility
-----------------------------------------+--------------------------------

Comment (by afercia):

 Well "Primary" and "Secondary" won't help in any case. They need to be
 renamed to something like "Blue" and "Dark blue" otherwise users won't
 have a clue what those colors are. Maybe it's a matter of terminology: I'd
 call these the ''default'' values of the ''custom'' colors.

 > that would be on the theme to not provide a name for the custom color,
 which would then trigger the behavior you describe in falling back to the
 hex value.

 Looking at what Twenty Nineteen does, see
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 content/themes/twentynineteen/functions.php?rev=44382&marks=145-154#L141

 I'm not sure how a theme can ''not'' provide a name for a custom color,
 given the default values need a name. Instead, when users set a ''custom
 value'' via the hue picker, we can't predict the color name. I'm wondering
 if there's a way to make ''custom values'' fallback to the hex code.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46698#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list