[wp-trac] [WordPress Trac] #45845: Use get_user_by in check_password_reset_key

WordPress Trac noreply at wordpress.org
Tue Apr 23 22:10:17 UTC 2019

#45845: Use get_user_by in check_password_reset_key
 Reporter:  spacedmonkey              |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  reopened
 Priority:  normal                    |   Milestone:  5.2
Component:  Users                     |     Version:  3.1
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  performance

Comment (by spacedmonkey):

 Thanks for the feedback @desrosj . Really helped.

 In [https://core.trac.wordpress.org/attachment/ticket/45845/45845.3.diff
 45845.3.diff] fixes the tests. Just calling `clean_user_cache` makes the
 tests pass. I personally believe the old tests were invalid and this fix
 is fine. Not sure if this breaking change.

 I am going to leave this up to @SergeyBiryukov to commit in 5.2 or punt.

Ticket URL: <https://core.trac.wordpress.org/ticket/45845#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list